Fix propagation of LocalLocalization #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
force-pushed
the
m-sasha/fix-local-localization-propagation
branch
from
017b1b6
to
81acb71
Compare
igordmn
reviewed
Mar 19, 2024
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/PlatformCompositionLocals.kt
Show resolved
Hide resolved
…ow and from window into child scenes (e.g. popup).
m-sasha
force-pushed
the
m-sasha/fix-local-localization-propagation
branch
from
81acb71
to
b1084dd
Compare
igordmn
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the user-provided
LocalLocalizationwas overwritten in new scene scope (e.g. Window, Popup).This PR uses
providesDefaultto provide theLocalLocalizationfor a new scene, which avoids overwriting any user-provided one.Testing
Test: Added new unit tests.