Introduce ComposeViewport function that renders content in parent container #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
reviewed
Mar 21, 2024
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> |
There was a problem hiding this comment.
This line was necessary for proper aspect ration on mobile devices (in Chrome Android).
|
|
||
| @OptIn(ExperimentalComposeUiApi::class) | ||
| fun main() { | ||
| CanvasBasedWindow("Compose/JS sample", canvasElementId = "canvas1") { |
There was a problem hiding this comment.
Here I see some lines deleted, but no new API used here :)
So fun main does nothing here. Not intentional I guess?
There was a problem hiding this comment.
yep, sorry, this was due to commit not being actually happened because of signup configuration
| @@ -18,24 +18,13 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="UTF-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
There was a problem hiding this comment.
<meta name="viewport" content="width=device-width, initial-scale=1.0"> - better to keep it here too
eymar
approved these changes
Mar 21, 2024
MatkovIvan
reviewed
Mar 22, 2024
|
|
||
| /** | ||
| * EXPERIMENTAL! Might be deleted or changed in the future! |
There was a problem hiding this comment.
It should be marked with experimental annotation instead of comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.