Prevent a few unnecessary recompositions in Popup and DesktopMenu. #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Apr 2, 2024
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Popup.skiko.kt
Show resolved
Hide resolved
|
This isn't a must-have PR. I started working on it when I noticed that So I decided to pivot to slightly improving the code instead :-) |
igordmn
approved these changes
Apr 2, 2024
MatkovIvan
reviewed
Apr 3, 2024
| @@ -392,11 +390,15 @@ fun Popup( | |||
| onKeyEvent: ((KeyEvent) -> Boolean)? = null, | |||
| content: @Composable () -> Unit | |||
| ) { | |||
| val currentOnDismissRequest by rememberUpdatedState(onDismissRequest) | |||
| val currentOnKeyEvent by rememberUpdatedState(onKeyEvent) | |||
There was a problem hiding this comment.
We need to do the same for dialog then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
runComposeUiTest.