New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2 crashing bugs in basic string processing for BasicTextField2 #1227

Merged

m-sasha merged 1 commit into jb-main from m-sasha/fix-tf2-text-bugs

Mar 27, 2024

m-sasha commented Mar 27, 2024

CharSequence.toCharArray had a bad range check and was crashing on an empty string.
GapBuffer.append was calling StringBuilder.appendRange passing length in the 3rd argument, but the expected value is endIndex.

Testing

Test: Manually.


          Fix 2 crashing bugs in basic string processing for BasicTextField2

25f5df2

m-sasha requested a review from igordmn

March 27, 2024 14:56

igordmn approved these changes

View reviewed changes

m-sasha merged commit ed472cc into jb-main

6 checks passed

m-sasha deleted the m-sasha/fix-tf2-text-bugs branch

March 27, 2024 18:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet