Don't crash, and allow selection in SelectionContainer to start when drag starts below the bounds of the visible text #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…drag starts below the bounds of the visible text.
igordmn
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Sounds reasonable to revert the change.
This change was originally introduced in 535fb6f.
The surrounding code was adapted for mobile "handles", and mouse position was equal to the bottom side of the handle, which was out of the bounds.
Now, it uses a proper mouse position (I tested localPosition), and everything should work correctly.
m-sasha
added a commit
that referenced
this pull request
Apr 4, 2024
…drag starts below the bounds of the visible text (#1230)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the explanation for this change here.
Proposed Changes
Use
textLayoutResult.sizerather thantextLayoutResult.multiParagraphwhen determining the text bounds for starting the selection inSelectionContainer. This is how Android does it.Testing
Test: Tested manually, and added a new unit test.
This PR should be verified by QA.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4555