-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HapticFeedback
on iOS
#1255
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Copyright 2024 The Android Open Source Project | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package androidx.compose.mpp.demo | ||
|
||
import androidx.compose.foundation.layout.Column | ||
import androidx.compose.foundation.layout.Spacer | ||
import androidx.compose.foundation.layout.height | ||
import androidx.compose.foundation.layout.padding | ||
import androidx.compose.material.Button | ||
import androidx.compose.material.Text | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.hapticfeedback.HapticFeedbackType | ||
import androidx.compose.ui.platform.LocalHapticFeedback | ||
import androidx.compose.ui.unit.dp | ||
|
||
val HapticFeedbackExample = Screen.Example("Haptic feedback") { | ||
val feedback = LocalHapticFeedback.current | ||
|
||
Column(modifier = Modifier.padding(16.dp)) { | ||
Button(onClick = { | ||
feedback.performHapticFeedback(HapticFeedbackType.TextHandleMove) | ||
}) { | ||
Text("TextHandleMove") | ||
} | ||
|
||
Spacer(Modifier.height(16.dp)) | ||
|
||
Button(onClick = { | ||
feedback.performHapticFeedback(HapticFeedbackType.LongPress) | ||
}) { | ||
Text("LongPress") | ||
} | ||
} | ||
} | ||
|
||
val IosSpecificFeatures = Screen.Selection( | ||
"iOS-specific features", | ||
NativeModalWithNaviationExample, | ||
HapticFeedbackExample, | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* | ||
* Copyright 2024 The Android Open Source Project | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package androidx.compose.ui.hapticfeedback | ||
|
||
import platform.UIKit.UIImpactFeedbackGenerator | ||
import platform.UIKit.UISelectionFeedbackGenerator | ||
|
||
// TODO: minor UX improvement, add `prepare()` calls when internal APIs that use HapticFeedback | ||
// to reduce haptic feedback latency | ||
// see https://developer.apple.com/documentation/uikit/uifeedbackgenerator | ||
internal fun HapticFeedback() = object : HapticFeedback { | ||
private val impactGenerator = UIImpactFeedbackGenerator() | ||
private val selectionGenerator = UISelectionFeedbackGenerator() | ||
|
||
override fun performHapticFeedback(hapticFeedbackType: HapticFeedbackType) { | ||
when (hapticFeedbackType) { | ||
HapticFeedbackType.LongPress -> impactGenerator.impactOccurred() | ||
HapticFeedbackType.TextHandleMove -> selectionGenerator.selectionChanged() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just to highlight: it looks like haptics will also work for text inputs handle moves, which is not standard for iOS. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed. But it's dictated by |
||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,8 +25,10 @@ import androidx.compose.runtime.MutableState | |
import androidx.compose.runtime.mutableStateOf | ||
import androidx.compose.ui.LocalSystemTheme | ||
import androidx.compose.ui.SystemTheme | ||
import androidx.compose.ui.hapticfeedback.HapticFeedback | ||
import androidx.compose.ui.interop.LocalUIViewController | ||
import androidx.compose.ui.interop.UIKitInteropContext | ||
import androidx.compose.ui.platform.LocalHapticFeedback | ||
import androidx.compose.ui.platform.LocalLifecycleOwner | ||
import androidx.compose.ui.platform.PlatformContext | ||
import androidx.compose.ui.platform.PlatformWindowContext | ||
|
@@ -426,6 +428,7 @@ internal fun ProvideContainerCompositionLocals( | |
content: @Composable () -> Unit, | ||
) = with(composeContainer) { | ||
CompositionLocalProvider( | ||
LocalHapticFeedback provides HapticFeedback(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It will be recreated on each recomposition There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, moved it to |
||
LocalUIViewController provides this, | ||
LocalInterfaceOrientation provides interfaceOrientationState.value, | ||
LocalSystemTheme provides systemThemeState.value, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to have
fun
+ anonymousobject
instead of just aclass
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, looked liked a fine place to use this idiom, but made it
CupertionHapticFeedback
class