iOS support LiveRegion semantics in a11y
#1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalavei
approved these changes
Apr 11, 2024
| focusedElement?.semanticsNodeId?.let { | ||
| accessibilityElementsMap[it] | ||
| } | ||
| null // No need to refocus to anything |
There was a problem hiding this comment.
Seems the old code fixed a case when scroll to next/prev page happens when the user swipes right/left to go to the next/prev element in the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add
UIAccessibilityTraitUpdatesFrequentlyto elements with associatedSemanticsNodehaving aLiveRegionproperty.Don't return a non-null refocused element if it's the same one before the sync unless it needs to happen (during the scroll to trigger private API).
This prevents accessibility focus change (forcing it to previous element) if the semantics tree is synced continuously due to bug in iOS (UIAccessibilityFocusedElement returns older value)
Testing
Test: When a focused accessibility element has a
LiveRegion, it will voice update in a given element.Issues Fixed
Incorrect refocusing when semantics are synced continuously.