Check whether event type is KeyDown after processing typed events. #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Apr 11, 2024
| @@ -76,10 +76,6 @@ internal abstract class TextFieldKeyEventHandler { | |||
| singleLine: Boolean, | |||
| onSubmit: () -> Unit | |||
| ): Boolean { | |||
| if (event.type != KeyEventType.KeyDown) { | |||
There was a problem hiding this comment.
On the desktop, typed events are not KeyDown events
Since the changes in common:
- Will it still work on Android?
- Should we fix it in AOSP first?
There was a problem hiding this comment.
- I think so.
- I'm talking to Zach about it.
There was a problem hiding this comment.
Let's slowly change our process to make a fix in AOSP first, and then cherry-pick it after merging to androidx-main.
And merge commonMain changes only if we need them soon.
Not sure about this fix. There are 2 factors:
- we need to merge it before 1.6.10-rc01
- the
androidx-maincode might be changed a lot right now and isn't worth upstreaming. So we just fix a small bug for just 1.6.10
There was a problem hiding this comment.
This part of the code hasn't changed in androidx-main tip, so it's a very easy upstreaming.
m-sasha
force-pushed
the
m-sasha/fix-btf2-input-processing
branch
from
ff2c78a
to
cc80000
Compare
MatkovIvan
approved these changes
Apr 12, 2024
igordmn
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In BasicTextField2 input processing: Ignore non-
KeyDownevents only after processing typed events.On the desktop, typed events are not
KeyDownevents, so checking forKeyDownfirst prevents processing typed events completely.Testing
Test: Tested a
BasicTextField2manually.