-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending KeyEvents from IME #1297
Conversation
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/platform/BackingTextArea.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/platform/BackingTextArea.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/platform/BackingTextArea.kt
Outdated
Show resolved
Hide resolved
Merged jb-main since it contained fixes for failing pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM, but I'd wait second reviewer
@@ -37,7 +37,9 @@ internal class WebImeInputService(parentInputService: InputAwareInputService) : | |||
onEditCommand: (List<EditCommand>) -> Unit, | |||
onImeActionPerformed: (ImeAction) -> Unit | |||
) { | |||
backingTextArea = BackingTextArea(imeOptions, onEditCommand, onImeActionPerformed) | |||
backingTextArea = BackingTextArea(imeOptions, onEditCommand, onImeActionPerformed) { evt -> | |||
sendKeyEvent(evt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this receives multiple callbacks, I'd prefer named parameters instead of trailing lambda syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please, add Release Notes as in the template
Release Notes
Features - Web