Initial iOS floating cursor support #1312
Merged
+73
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for another feature! |
Sure thing. Please test how it works on older iOS versions if you can. Not sure why the issue author decided that it was added in the iOS 17, I believe it has been available for a long long time |
Closed
ASalavei
approved these changes
May 23, 2024
There was a problem hiding this comment.
LGTM. Tests passed. Sorry for the delay.
cc @elijah-semyonov @mazunin-v-jb
mazunin-v-jb
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
@alexzhirkevich, thanks for contribution!
and sorry for huge delay
LGTM too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Initial iOS floating cursor support.
RPReplay_Final1713910413.MP4
Testing
Test: hold space bar and move the cursor
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4593