Fix precise mouse wheel detection #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For testing, the mouse which I encountered issues with was a Surface Precision Mouse paired by bluetooth to Windows 11. |
igordmn
approved these changes
May 28, 2024
There was a problem hiding this comment.
Tested on:
- Windows, Logitech mouse with precise scrolling enabled/disabled - scrolling is smooth
- macOs touchpad - scrolling is smooth
- macOs the same mouse - scrolling is rough (isn't animated, before and after the fix)
Regarding the last point - worth to consider always enabling animation (maybe later), we can run it undispatched, so the first frame can scroll to the target position.
Running animation undispatched probably can also simplify the code, it allows getting rid of shouldApplyImmediately.
I don't remember why we decided conditionally enable this, probably there were some unresponsiveness because of extra frames or dispatching nature of animation.
MatkovIvan
added a commit
that referenced
this pull request
May 29, 2024
Fix precise mouse wheel detection that might cause missing animations Fixes https://kotlinlang.slack.com/archives/C01D6HTPATV/p1713977814126099 ## Testing Should be covered by existing tests + manually. ## Release Notes ### Fixes - Desktop - Fix possible scrolling without animation on some mouse models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix precise mouse wheel detection that might cause missing animations
Fixes https://kotlinlang.slack.com/archives/C01D6HTPATV/p1713977814126099
Testing
Should be covered by existing tests + manually.
Release Notes
Fixes - Desktop