Commonize lifecycle tests #1330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… any supported platform For some platforms, surrogate Main threads are provided
some tests were minimally adjusted due to missing multi-platform APIs
igordmn
approved these changes
Apr 30, 2024
lifecycle/lifecycle-runtime/src/nativeTest/kotlin/androidx/lifecycle/runLifecycleTest.native.kt
Show resolved
Hide resolved
MatkovIvan
approved these changes
May 2, 2024
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2019 The Android Open Source Project | |||
| * Copyright 2024 The Android Open Source Project | |||
There was a problem hiding this comment.
Please revert updating years in header comments
| import java.util.concurrent.atomic.AtomicInteger | ||
| import androidx.kruth.assertThat | ||
| import kotlinx.atomicfu.atomic | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commonize Lifecycle tests.
These tests are heavily relied on
Dispatchers.Main, which involves intricate test environment setup.After PR is ready, I'm not going to merge it, instead I'll upstream it to
androidxrepository directly.Testing
Run
./gradlew :lifecycle:lifecycle-runtime:allTests