[web] Process keydown and keyup keys for identified keys from virtual keyboard #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
May 30, 2024
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/platform/BackingTextArea.kt
Outdated
Show resolved
Hide resolved
eymar
approved these changes
May 31, 2024
There was a problem hiding this comment.
I'm thinking about a test which can be added here:
- the test would send a touch event to make our internal state (keyboardModeState) switch to
KeyboardModeState.Virtual(a tap on the TextField) - it would send Keyboard events into the textarea
- it would check that Modifier.onKeyEvent receives the events
What do you think?
Schahen
force-pushed
the
shagen/physical-keys-in-virtual-keyboard
branch
from
d209826
to
531339c
Compare
eymar
reviewed
Jun 10, 2024
| @@ -52,7 +52,7 @@ class SelectionContainerTests : OnCanvasTests { | |||
| fun setup() { | |||
| // Because AfterTest is fixed only in kotlin 2.0 | |||
| // https://youtrack.jetbrains.com/issue/KT-61888 | |||
| document.getElementById(canvasId)?.remove() | |||
| commonAfterTest() | |||
There was a problem hiding this comment.
The tests here failed on CI.
Could this change be a reason of the test failure?
There was a problem hiding this comment.
although locally all the tests pass. weird :(
There was a problem hiding this comment.
Tried to rerun the CI, but same failure.
for some reason I think commonAfterTest might be a reason.
There was a problem hiding this comment.
let me just return everything as it was and see how it goes
the reason might be parallelization or whatever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues with pressing some virtual keys that don't change the input value - like navigation with arrows.
Also, this will make finally possible to switch to KeybardEvent::key-backed toComposeEvent conversion