iOS fix keyboard crash #1383
Merged
iOS fix keyboard crash #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Jun 4, 2024
| } | ||
|
|
||
| val key = specialTypeKey ?: pressKey?.keyCode?.let { Key(it) } ?: Key.Unknown | ||
| val codePoint = pressKey?.characters?.firstOrNull()?.code ?: 0 |
There was a problem hiding this comment.
Please reuse our internal helper String.codePointAt(index: Int): CodePoint instead of firstOrNull
There was a problem hiding this comment.
I feel hesitant to introduce this change in this PR:
- I'm not owning this piece of code.
- This is out of the scope of the fix.
- So far we have no issues related to it.
There was a problem hiding this comment.
Let's add explicit TODO at least
MatkovIvan
reviewed
Jun 4, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/input/key/KeyEvent.uikit.kt
Outdated
Show resolved
Hide resolved
…ey/KeyEvent.uikit.kt Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
Schahen
approved these changes
Jun 4, 2024
| // can be potentially nil on TVOS, this will cause a crash | ||
| val uiKey = requireNotNull(key) { | ||
| "UIPress with null key is not supported" | ||
| val pressKey = key |
There was a problem hiding this comment.
Well, if we don't need any additional check then (why btw?) then this variable is redundant and we can just use key
There was a problem hiding this comment.
Aha, removed extra variable and avoided shadowing this.key with local key.
MatkovIvan
approved these changes
Jun 4, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/input/key/KeyEvent.uikit.kt
Outdated
Show resolved
Hide resolved
…ey/KeyEvent.uikit.kt Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle UIPress with
key == nilFixes a crash JetBrains/compose-multiplatform#4911
Testing
The reported issue doesn't reproduce anymore.
Release Notes
Fixes - iOS