Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt focus interop code to Compose 1.7 changes #1398

Merged
merged 5 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. Adapt focus interop code to Compose 1.7 changes

    Fixes JetBrains/compose-multiplatform#2944
    Fixes JetBrains/compose-multiplatform#4919
    Fixes https://youtrack.jetbrains.com/issue/COMPOSE-1212/Integration.-Check-changes-in-FocusOwnerImpl
    
    After https://android-review.googlesource.com/c/platform/frameworks/support/+/2813125, there are some changes that affected our code for focus interop with ComposePanel/SwingPanel:
    - the root node no longer focusable
    - FocusOwnerImpl now has iterop callbacks and our own modification of this file (in jb-main, integration was reset) doesn't work anymore
    
    ## Testing
    - added new tests
    - ComposeFocusTest now pass
    
    ## Release notes
    ### Fixes - Multiple platforms
    - Fix "ComposePanel. Focus moves to child after focusing/unfocusing the main window"
    igordmn committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    942bbfc View commit details
    Browse the repository at this point in the history
  2. Dump API

    igordmn committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f2225ff View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'refs/remotes/origin/integration' into i…

    …gor.demin/integration-fix-focus
    igordmn committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    7c02d1b View commit details
    Browse the repository at this point in the history
  4. Discussions

    igordmn committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1e5a9e0 View commit details
    Browse the repository at this point in the history
  5. Discussions

    igordmn committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    bbf01e8 View commit details
    Browse the repository at this point in the history