forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new skiko API to provide font fallbacks #1400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
commented
Jun 11, 2024
private val registered: MutableSet<String> = HashSet() | ||
private val typefacesCache: Cache<String, SkTypeface> = ExpireAfterAccessCache( | ||
60_000_000_000 // 1 minute | ||
) | ||
|
||
init { | ||
fonts.setDefaultFontManager(FontMgr.default) | ||
fonts.setDefaultFontManager(FontMgr.defaultWithFallbackFontProvider(fontProvider)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It affects all targets.
In most cases desktop and ios won't be affected, because the default font manager can provide the fallbacks, and therefore the new logic in skiko won't be used.
igordmn
approved these changes
Jun 13, 2024
MatkovIvan
reviewed
Jun 17, 2024
compose/mpp/demo/src/wasmJsMain/kotlin/androidx/compose/mpp/demo/main.js.kt
Outdated
Show resolved
Hide resolved
igordmn
approved these changes
Jun 20, 2024
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Description:
This PR updates the implementation details of
FontCache
in skikoMain:Fixes:
With this change, it's possible to mix different characters in one Text without composing the text using AnnotatedString.
Although, when the most of glyphs are known to be from a particular font, it's more performant to specify the font explicitly when using Text(...) component or via Theme.
Usage example:
The fallbacks won't work automatically, the fallback fonts should be preloaded like this:
Testing
./gradlew :compose:mpp:demo:wasmJsBrowserRun
)This should be tested by QA
Release Notes
Fixes - Web