Fix text input popup position #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JetBrains/compose-multiplatform#2040 Fixes JetBrains/compose-multiplatform#2493 notifyFocusedRect was deprecated in https://android-review.googlesource.com/c/platform/frameworks/support/+/1959647 On Android, before deprecation this method was used to scroll to the focused text input. This functionality was extracted to the text field itself, but we had another functionality on the other platforms. On Desktop we show text input popup near text input (for some languages): JetBrains/compose-multiplatform#2040 (comment) I think that this method is the right choice to implement this functionality, but I am not completely sure. Here my thoughts about alternatives: 1. Use BringIntoViewRequester. Not sure that it is possible, because its purpose - to show the view to the user, not use the passed information to determine the text popup position 2. Get information about focused area from another source that is not related to text input. For example, we can inject FocusManager, and retrieve the focused rect from it. Probably not a good idea, because the rect of arbitrary focused node isn't the same thing as the rect of focused input area.
igordmn
changed the title
eymar
reviewed
Dec 1, 2022
|
|
||
| // TODO remove `Deprecated`, if it is removed in AOSP repository | ||
| @Suppress("DEPRECATION") | ||
| textInputSession.notifyFocusedRect( |
There was a problem hiding this comment.
Where/how can we observe the focus rect changes? Do we have an API for that?
There was a problem hiding this comment.
I didn't found such API, but we can write a new one, if we need. Anyway, it seems if we write something like LocalFocusManager.focusedRect it will be not what we want. We want the rect for text input. And here we can get it.
There was a problem hiding this comment.
What I mean is that I see a few places which call notifyFocusedRect, but I don't understand which part actually "observers" the changes so input popup position can be set correctly?
There was a problem hiding this comment.
notifyFocusedRect subscribed on 2 things:
Modifier.onGloballyPositionedof the text field, which is called every time its repositioned relative to the window.Modifier.onFocusChangedwhich triggers when the focus of text field changes.
I realized, that we don't subscribe on cursor changes. We rely on a side effect of onGloballyPositioned, which accidentally is called when we change the cursor position (but it seems, it shouldn't). I will investigate, should we also call notifyFocusedRect somewhere else.
There was a problem hiding this comment.
Call it on relayout too now
eymar
approved these changes
Dec 2, 2022
igordmn
added a commit
that referenced
this pull request
Dec 5, 2022
* PlatformTextInputService. Undeprecate notifyFocusedRect Fixes JetBrains/compose-multiplatform#2040 Fixes JetBrains/compose-multiplatform#2493 notifyFocusedRect was deprecated in https://android-review.googlesource.com/c/platform/frameworks/support/+/1959647 On Android, before deprecation this method was used to scroll to the focused text input. This functionality was extracted to the text field itself, but we had another functionality on the other platforms. On Desktop we show text input popup near text input (for some languages): JetBrains/compose-multiplatform#2040 (comment) I think that this method is the right choice to implement this functionality, but I am not completely sure. Here my thoughts about alternatives: 1. Use BringIntoViewRequester. Not sure that it is possible, because its purpose - to show the view to the user, not use the passed information to determine the text popup position 2. Get information about focused area from another source that is not related to text input. For example, we can inject FocusManager, and retrieve the focused rect from it. Probably not a good idea, because the rect of arbitrary focused node isn't the same thing as the rect of focused input area. * Keep @deprecated until we don't merget this into AOSP
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
* PlatformTextInputService. Undeprecate notifyFocusedRect Fixes JetBrains/compose-multiplatform#2040 Fixes JetBrains/compose-multiplatform#2493 notifyFocusedRect was deprecated in https://android-review.googlesource.com/c/platform/frameworks/support/+/1959647 On Android, before deprecation this method was used to scroll to the focused text input. This functionality was extracted to the text field itself, but we had another functionality on the other platforms. On Desktop we show text input popup near text input (for some languages): JetBrains/compose-multiplatform#2040 (comment) I think that this method is the right choice to implement this functionality, but I am not completely sure. Here my thoughts about alternatives: 1. Use BringIntoViewRequester. Not sure that it is possible, because its purpose - to show the view to the user, not use the passed information to determine the text popup position 2. Get information about focused area from another source that is not related to text input. For example, we can inject FocusManager, and retrieve the focused rect from it. Probably not a good idea, because the rect of arbitrary focused node isn't the same thing as the rect of focused input area. * Keep @deprecated until we don't merget this into AOSP
igordmn
added a commit
that referenced
this pull request
Nov 15, 2023
* PlatformTextInputService. Undeprecate notifyFocusedRect Fixes JetBrains/compose-multiplatform#2040 Fixes JetBrains/compose-multiplatform#2493 notifyFocusedRect was deprecated in https://android-review.googlesource.com/c/platform/frameworks/support/+/1959647 On Android, before deprecation this method was used to scroll to the focused text input. This functionality was extracted to the text field itself, but we had another functionality on the other platforms. On Desktop we show text input popup near text input (for some languages): JetBrains/compose-multiplatform#2040 (comment) I think that this method is the right choice to implement this functionality, but I am not completely sure. Here my thoughts about alternatives: 1. Use BringIntoViewRequester. Not sure that it is possible, because its purpose - to show the view to the user, not use the passed information to determine the text popup position 2. Get information about focused area from another source that is not related to text input. For example, we can inject FocusManager, and retrieve the focused rect from it. Probably not a good idea, because the rect of arbitrary focused node isn't the same thing as the rect of focused input area. * Keep @deprecated until we don't merget this into AOSP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CL: https://android-review.googlesource.com/c/platform/frameworks/support/+/2319924
the only difference with the CL is that we still keep this method Deprecated, to avoid confusion in the future, if we fix this issue another way.
If this CL will be merged, during rebase most probably will be conflicts. Just drop this commit then.
Fixes JetBrains/compose-multiplatform#2040
Fixes JetBrains/compose-multiplatform#2493
notifyFocusedRect was deprecated in https://android-review.googlesource.com/c/platform/frameworks/support/+/1959647
On Android, before deprecation this method was used to scroll to the focused text input.
This functionality was extracted to the text field itself, but we had another functionality on the other platforms.
On Desktop we show text input popup near text input (for some languages):
JetBrains/compose-multiplatform#2040 (comment)
I think that this method is the right choice to implement this functionality, but I am not completely sure. Here my thoughts about alternatives: