Don't rely on AWT in rememberCursorPositionProvider #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walingar
commented
Mar 10, 2023
| ) | ||
| } | ||
| val pointerPositions = LocalPointerPositions.current | ||
| val cursorPoint = remember { pointerPositions.entries.first().value.round() } |
There was a problem hiding this comment.
In the future when @igordmn will merge his changes about multi-touch support, we can filter by mouse here.
m-sasha
reviewed
Mar 11, 2023
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/ComposeScene.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/ComposeScene.skiko.kt
Outdated
Show resolved
Hide resolved
m-sasha
reviewed
Mar 13, 2023
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.desktop.kt
Outdated
Show resolved
Hide resolved
Walingar
force-pushed
the
nr/tooltip-without-awt
branch
from
27a5bac
to
22559d6
Compare
m-sasha
reviewed
Mar 18, 2023
compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/DesktopCursorPositionTest.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/DesktopCursorPositionTest.kt
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.desktop.kt
Outdated
Show resolved
Hide resolved
igordmn
approved these changes
Mar 20, 2023
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.desktop.kt
Outdated
Show resolved
Hide resolved
…ts instead To implement it current pointer positions should be provided. Add test for rememberCursorPositionProvider. Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
Walingar
force-pushed
the
nr/tooltip-without-awt
branch
from
3a75022
to
3fb1d24
Compare
|
Rebased on Sasha's changes (squashed my commits into one), also removed some redundant waits. Some waits are still needed |
Walingar
commented
Mar 20, 2023
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.desktop.kt
Show resolved
Hide resolved
m-sasha
approved these changes
Mar 21, 2023
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.desktop.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
LocalPointerPositionsthat provides a way to get the current position of pointers. It is used inrememberCursorPositionProviderrememberCursorPositionProviderdoesn't rely on AWT anymoreTesting
Test: newly introduced
TooltipAreaTestandDesktopCursorPositionTestIssues Fixed
Fixes: JetBrains/compose-multiplatform#2821