Implement iOS native feel scrolls for large text fields #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-semyonov
changed the title
|
Added Android implementation here: #775 |
dima-avdeev-jb
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Construct and pass CupertinoOverscrollEffect inside Modifier.textFieldScrollable. Adapt non-null OverscrollEffect logic in text field to mimic behavior of LazyList to avoid text clipping through the container.
Testing
Test: TBD
Issues Fixed
Fixes: https://youtrack.jetbrains.com/issue/COMPOSE-336/iOS-native-scroll-physics-for-long-TextField
Note
TextFieldDecorationBox uses padding to layout internal text. textFieldScrollable is applied to entire container (with decoration box) and is not aware of it, so it can't do proper clipping when Modifier.offset is applied without a breaking internal API change.
Videos
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-08-25.at.11.40.12.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-08-25.at.11.53.09.mp4