Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect material.ExposedDropdownMenuBox in common #793

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Expect material.ExposedDropdownMenuBox in common #793

merged 5 commits into from
Sep 6, 2023

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

  • Expect ExposedDropdownMenuBox in common and implement for skiko
  • Add test usage in mpp demo app

API Changes

+@ExperimentalMaterialApi
+@Composable
+expect fun ExposedDropdownMenuBox(
+    expanded: Boolean,
+    onExpandedChange: (Boolean) -> Unit,
+    modifier: Modifier = Modifier,
+    content: @Composable ExposedDropdownMenuBoxScope.() -> Unit
+)

Testing

Test: Try to use ExposedDropdownMenuBox from common or look at mpp demo

Base automatically changed from ivan.matkov/common-exposed-dropdown3 to jb-main September 6, 2023 12:10
@MatkovIvan MatkovIvan force-pushed the ivan.matkov/common-exposed-dropdown branch from 9b9aeb4 to 48417c4 Compare September 6, 2023 12:12
@MatkovIvan MatkovIvan merged commit fb7bb8b into jb-main Sep 6, 2023
3 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/common-exposed-dropdown branch September 6, 2023 13:09
igordmn pushed a commit that referenced this pull request Nov 15, 2023
@MatkovIvan @igordmn
ui. popup. Expect material.ExposedDropdownMenuBox in common (#793)
a815b50 
* Expect ExposedDropdownMenuBox in common

* Add ExposedDropdownMenuSample

* Move ExposedDropdownMenuDefaults to common

* Simplify updateHeight

* Fix demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-sasha m-sasha m-sasha approved these changes

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
changes in API changes in common
Projects
None yet
Milestone
No milestone
3 participants
@MatkovIvan @m-sasha @igordmn