Use CADisplayLink.targetTimestamp value as an argument for frameClock.sendFrame #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use
CADisplayLink.targetTimestamp
instead of current immediate timestamp for moving theComposeScene.frameClock
.Aggregate MetalRedrawer callbacks into a single interface object. Remove for-test callbacks, copied from and previously used in skiko tests.
Testing
Test: N/A
Issues Fixed
Fixes:
withFrameNanos
depending on actual execution time and not vsync timeline.