Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS textfield scroll to caret and one line before #804

Merged
merged 3 commits into from
Sep 13, 2023
Merged

iOS textfield scroll to caret and one line before #804

merged 3 commits into from
Sep 13, 2023

Conversation

dima-avdeev-jb
Copy link

@dima-avdeev-jb dima-avdeev-jb commented Sep 11, 2023 •
edited

Proposed Changes

  • Change logic when TextField scrolls to carret on iOS

Testing

Test:

  • Run iOS Demo
  • Open TextField, Almost Fullscreen example
  • Tap and place carret on 3-th line of text
  • Scroll TextField to the bottom
  • Start typing
  • TextField should be scrolled to 2-nd line of text

Issues Fixed

https://youtrack.jetbrains.com/issue/COMPOSE-391/M3-iOS-TextField-scroll-to-carret

@dima-avdeev-jb dima-avdeev-jb self-assigned this Sep 11, 2023
igordmn
igordmn approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me (tested with copy-pasting them to desktop target)

@dima-avdeev-jb dima-avdeev-jb merged commit 7dbe194 into jb-main Sep 13, 2023
3 of 4 checks passed
@dima-avdeev-jb dima-avdeev-jb deleted the dima.avdeev/ios-textfield-scroll-to-caret branch September 13, 2023 13:42
igordmn pushed a commit that referenced this pull request Nov 15, 2023
@dima-avdeev-jb @igordmn
foundation. textfield. iOS textfield scroll to caret and one line bef…
eb8d815 
…ore (#804)

Change logic when TextField scrolls to carret on iOS

https://youtrack.jetbrains.com/issue/COMPOSE-391/M3-iOS-TextField-scroll-to-carret
igordmn pushed a commit that referenced this pull request Nov 16, 2023
@dima-avdeev-jb @igordmn
textfield [refactoring] foundation. textfield. iOS textfield scroll t…
32d2136 
…o caret and one line before (#804)

Change logic when TextField scrolls to carret on iOS

https://youtrack.jetbrains.com/issue/COMPOSE-391/M3-iOS-TextField-scroll-to-carret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igordmn igordmn igordmn approved these changes

@mazunin-v-jb mazunin-v-jb mazunin-v-jb approved these changes

Assignees

@dima-avdeev-jb dima-avdeev-jb

Labels
changes in common
Projects
None yet
Milestone
No milestone
3 participants
@dima-avdeev-jb @igordmn @mazunin-v-jb