-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make desktop preview task fully configuration cache compliant (#4410)
The issue was in a case where there wasn't a direct dependency on the skiko artifact, the task would attempt to get one at task execution time. This moves that to task configuration time.
- Loading branch information
Showing
7 changed files
with
63 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
gradle-plugins/compose/src/test/test-projects/misc/jvmPreview/common/build.gradle
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
plugins { | ||
id 'org.jetbrains.kotlin.multiplatform' | ||
id 'org.jetbrains.compose' | ||
} | ||
|
||
kotlin { | ||
jvm('desktop') {} | ||
|
||
sourceSets { | ||
commonMain.dependencies { | ||
api compose.runtime | ||
api compose.foundation | ||
api compose.material | ||
api compose.uiTooling | ||
} | ||
} | ||
} |
21 changes: 21 additions & 0 deletions
21
...compose/src/test/test-projects/misc/jvmPreview/common/src/commonMain/kotlin/composable.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* Copyright 2020-2021 JetBrains s.r.o. and respective authors and developers. | ||
* Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE.txt file. | ||
*/ | ||
|
||
import androidx.compose.material.Text | ||
import androidx.compose.material.Button | ||
import androidx.compose.runtime.* | ||
|
||
@Composable | ||
fun ExampleComposable() { | ||
var text by remember { mutableStateOf("Hello, World!") } | ||
|
||
Button(onClick = { | ||
text = "Hello, $platformName!" | ||
}) { | ||
Text(text) | ||
} | ||
} | ||
|
||
val platformName: String = "Desktop" |
8 changes: 8 additions & 0 deletions
8
...ns/compose/src/test/test-projects/misc/jvmPreview/common/src/commonMain/kotlin/preview.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.desktop.ui.tooling.preview.Preview | ||
|
||
@Preview | ||
@Composable | ||
fun ExamplePreview() { | ||
ExampleComposable() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters