Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support localization of bundled strings #3360

Closed
igordmn opened this issue Jul 18, 2023 · 5 comments · Fixed by JetBrains/compose-multiplatform-core#1158
Closed

Support localization of bundled strings #3360

igordmn opened this issue Jul 18, 2023 · 5 comments · Fixed by JetBrains/compose-multiplatform-core#1158
Assignees
@m-sasha
Labels
commonization enhancement New feature or request material3 p:high High priority

Comments

@igordmn
Copy link
Collaborator

igordmn commented Jul 18, 2023 •
edited

Currently, material3 has English Strings hardcoded:
image
@igordmn igordmn added enhancement New feature or request p:high High priority labels Jul 18, 2023
@igordmn
Copy link
Collaborator Author

igordmn commented Jul 18, 2023 •
edited

A possible solution is to provide a CompositionLocal.

@igordmn
Copy link
Collaborator Author

igordmn commented Jul 18, 2023

Another solution - support strings.xml, similar to Android way

@igordmn igordmn mentioned this issue Jul 18, 2023
Merged
@igordmn igordmn changed the title material3. Support localization Support localization Feb 9, 2024
@igordmn igordmn changed the title Support localization Support localization of bundled strings Feb 9, 2024
@igordmn
Copy link
Collaborator Author

igordmn commented Feb 9, 2024 •
edited

Also in foundation/../BasicTooltipBoxInternal (Compose 1.6.0)

@gleb-skobinsky
Copy link

Hi, are there any plans to fix this issue, maybe some approximate dates? In our team, these English labels in otherwise completely Russian-language app look really bad

@dima-avdeev-jb
Copy link
Contributor

@gleb-skobinsky
Hello! We need some architectural changes between modules (artifacts) to solve this Issue. So, we need a time to plan it.

@m-sasha m-sasha mentioned this issue Mar 4, 2024
Merged
@m-sasha m-sasha self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-sasha m-sasha

Labels
commonization enhancement New feature or request material3 p:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Localize internal strings in ui, material and material3 JetBrains/compose-multiplatform-core
5 participants
@MatkovIvan @m-sasha @igordmn @gleb-skobinsky @dima-avdeev-jb