forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize internal strings in ui, material and material3 #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation in Material and Material3.
… corresponding Kotlin source. Use this for the `ui` module.
… handle %N$d and %N$s strings.
127b3fd
to
3156c0d
Compare
terrakok
reviewed
Mar 11, 2024
igordmn
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the user-visible strings Compose Multiplatform uses internally (e.g. "Copy" and "Paste" in context menus) are always in English. This PR adds translations of these strings to all the locales Android has localization for at https://github.com/androidx/androidx/tree/androidx-main/compose/ui/ui/src/androidMain/res
The translations are obtained by a Gradle task that check out the corresponding repository, reads the respective
strings.xml
files and writes Kotlin code with the translations.Limitations:
Locale.setDefault
before showing the UI.Note that this is a temporary solution until the official resources library is stable.
Note for changelog
To disable the localization of internal Compose strings and use the English version, set the system locale before showing any UI:
java.util.Locale.setDefault(java.util.Locale("en"))
Proposed Changes
ui
module to use a "Strings" mechanism similar to how localization is done in material and material3 modules.ui
,material
andmaterial3
modules.I recommend reviewing this PR commit-by-commit.
Testing
Test: Manually, and with some new unit tests.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#3360