-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resources: multimodule projects support #4229
Comments
Any progress on this issue? |
@xiaozhikang0916 |
Based on the response #4165 (comment), this will not be implemented. |
So, according to #4327 (comment) and #4165 (comment), if I need to use string resources in multiple modules with compose, I have to extract those resources in one public module and export all the resources by handwriting codes? |
This isn't really an acceptable solution. |
https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-images-resources.html
Currently, there are some limitations in underlying things that block us from doing this. We're working with Kotlin and other teams to make this happen. |
Please consider making the default visibility |
Is it possible to add at least a turn off switch to control the resource itself if it is not expected to use the resource? Or is it more recommended not to use the composeResources directory in this case? |
Could you explain your problem? I don't get it |
Main reasons: Other reasons: |
Thank a lot for the support! So far I see only |
# Changes * Add `Never` to `enum class ResourceClassGeneration` to disable the generation of Res class in the gradle plugin # Motivation As the [comment in issue 4229](#4229 (comment)) said, my team is not in the ecosystem of gradle, but organize the build steps in bazel. We want to follow the files layout but just disable the generation task of gradle and handle it by outself.
|
Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks. |
Describe the bug
Two modules has values/strings.xml cause compile error
Affected platforms
Select one of the platforms below:
If the bug is Android-only, report it in the Jetpack Compose tracker
Versions
To Reproduce
Steps and/or the code snippet to reproduce the behavior:
:resources:demo:androidApp:assembleDebug
Expected behavior
Compile succeed
Screenshots
![Screenshot 2024-02-04 at 13 05 06](https://private-user-images.githubusercontent.com/1487445/302078376-9e51439c-b422-47c0-a60c-0b4615ee1626.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2MTYwMjYsIm5iZiI6MTcyNDYxNTcyNiwicGF0aCI6Ii8xNDg3NDQ1LzMwMjA3ODM3Ni05ZTUxNDM5Yy1iNDIyLTQ3YzAtYTYwYy0wYjQ2MTVlZTE2MjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjVUMTk1NTI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWI2YjlhYjg5ZWQyNzczYjRkYjM1ZGRhZGMzZjczZGRmMzQwNDcxMmYxMzk1NGRlNDE3MDE5NWFhM2E3NzM3ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ._e9Q1O5OoyEERIzdIvUfPuH7ny6_zi4umgoD1u8DYZE)
The text was updated successfully, but these errors were encountered: