-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectionContainer
can't show options menu on iOS
#4322
Comments
It is not reproduced in version 1.6.0-alpha01, but is reproduced starting from version 1.6.0-beta01. |
@bonamanada jfyi |
@dima-avdeev-jb @mazunin-v-jb I am seeing this on compose 1.6.1 -- this is a pretty serious regression. Is there an ETA for a fix? |
Should be included in the next release (1.6.10) |
## Proposed Changes **Cherry-picked from androidx** Fix a typo in `SelectionManager.getContentRect()` that results in an invalid rect being calculated, causing text toolbar to not show under certain conditions. Fixes: b/332782845 Test: manual Change-Id: I153b99f4146d870182af2898d9a675ed6ffa15e4 ## Testing Test: Open test app, go Components -> Selection, try to select text in selection container ## Issues Fixed Fixes: appearing of editing menu in selection container in wrong position https://youtrack.jetbrains.com/issue/COMPOSE-1190/iOS-Selection-Container-cant-show-options-menu JetBrains/compose-multiplatform#4322 b/332782845 in Google ## Google CLA You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/. This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well. Co-authored-by: Albert Chang <mxalbert1996@gmail.com>
…1269) ## Proposed Changes - Added creating a text interaction view (which is required to show the edit menu by long press / double tap on the text) in case when there is no one (i.e. only selection container presents of the screen without any other text editing views) - Fixed its position on the screen (changes from androidx: #1270) ## Testing Test: Open test app, go Components -> Selection, try to select text in selection container ## Issues Fixed Fixes: - https://youtrack.jetbrains.com/issue/COMPOSE-1190/iOS-Selection-Container-cant-show-options-menu - JetBrains/compose-multiplatform#4322 ## Google CLA You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/. This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.
@mazunin-v-jb I just tested |
@brendanw beta01 doesn't contain that fix, please wait for the beta02 |
@mazunin-v-jb beta2 has fixed this issue, but there are still two issues:
|
I am also seeing the same two issues as @robxyy on beta02 |
@robxyy |
Describe the bug
SelectionContainer
can't show options menu on iOSAffected platforms
Select one of the platforms below:
Versions
To Reproduce
When long pressing
SelectionContainer
, the options menu can't be shown , likeCopy
...Expected behavior
Show options menu like Android
Screenshots
![](https://private-user-images.githubusercontent.com/9105106/305609339-4bfa8c3e-f068-4d3f-b27d-699c35f7e709.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2MDgzNDksIm5iZiI6MTcyNDYwODA0OSwicGF0aCI6Ii85MTA1MTA2LzMwNTYwOTMzOS00YmZhOGMzZS1mMDY4LTRkM2YtYjI3ZC02OTljMzVmN2U3MDkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjVUMTc0NzI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmVjNzEyNjU3ZDFkYzA0YTBiMjNkMmE1ODNkMDcwZjFiY2Q4NzI1NTYxNGY3NmNlMTdmMjAzOTk3MThiYzNjNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Ac2Ga9eoOF0EwWP2uhMvuXUbwD2BbCu9jZNkhkc4JZ0)
The text was updated successfully, but these errors were encountered: