-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Nested scrolling is not working properly #653
Desktop: Nested scrolling is not working properly #653
Comments
Any updates on this issue? |
1 similar comment
Any updates on this issue? |
@akurasov hello any plan for this issue? |
There are no specific plans about it yet |
Could this please be fixed? |
Are there any workarounds for this issue? |
Still no movement on this? It's been almost 2 years with no progress. Pull Refresh APIs are being introduced that rely on nested scroll, rendering them unusable on Desktop platforms. |
Any update on this? It makes |
Does Compose desktop supports Scafford + TopAppBar nested scroll&collapsed effect? I try to make it in compose desktop but the app bar didn’t collapse as Android side when I scrolled the content. |
Did you guys found any workaround? |
This bug still exists |
It was fixed in |
Unfortunately, it's still not fixed in version 1.6.0-dev1405 and 1.6.0-beta01. |
True, I've already checked this after the merge of Google's fix, but it seems that it requires changes from the multiplatform side too. I'll try to fix it before our 1.6 release, but no promises at the moment UPD: it does NOT included in 1.6.0 |
## Proposed Changes - Use `dispatchScroll` with a new `NestedScrollSource.Wheel` instead of direct call of `scrollBy`/`dispatchRawDelta` - Set scrolling priority to `MutatePriority.UserInput` during mouse wheel scroll animation - Move all scroll delta dispatching into a single coroutine - Remove threshold (logic where small delta was applied without animation), `shouldApplyImmediately` flag based on `isPreciseWheelScroll` handles it instead. - Wait `ProgressTimeout` after each mouse wheel event before resetting `isScrollInProgress` flag - Enable this logic by default (old "raw" dispatching failed our tests on iOS) ## Testing Test: Check "NestedScroll" page in mpp demo + unit tests ## Issues Fixed Fixes JetBrains/compose-multiplatform#653 Fixes JetBrains/compose-multiplatform#1423
NestedScrollConnectionSample from compose samples (link) is not working on desktop - toolbar suppose to move away when scrolling. Here in the sample onPreScroll method is never called. The sample works fine when run on Android.
Library version: 0.4.0-build182
OS: MacOS
The text was updated successfully, but these errors were encountered: