Add release instruction #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This was referenced Apr 24, 2023
MatkovIvan
pushed a commit
to MatkovIvan/compose-multiplatform
that referenced
this pull request
May 10, 2023
This CL adds a hoisted ScrollState to BasicTextField2 to enable horizontal and vertical scroll. Like the existing `BasicTextField`, BTF2 only supports single orientated scrolling. Single line configuration disables `softWrap` and enables horizontal scroll. Multi-line configuration does the exact opposite to enable vertical scroll. Cursor is kept in visible area only when it's shown (focused, editable). There is also a fix to clip test for `BasicTextField`. The previous test only looked at the area JetBrains#4, but in fact it needs to check JetBrains#2, JetBrains#3, JetBrains#4 for any spill from BasicTextField. // BasicTextField is JetBrains#1 // Wrapping box is all the area visible below ----- |1|2| ----- |3|4| ----- Relnote: N/A Test: :compose:foundation:foundation:cAT Change-Id: Iccac198dec2d2908c4c51ddfaf40dcb05515ce70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.