Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPOSE-338 Remove uikit experimental flag in gradle.properties #3747

Merged

Conversation

dima-avdeev-jb
Copy link
Contributor

Issue https://youtrack.jetbrains.com/issue/COMPOSE-338/remove-iOS-experimental-flag
No more need this line:
org.jetbrains.compose.experimental.uikit.enabled=true

@igordmn
Copy link
Collaborator

igordmn commented Sep 29, 2023

We should remove it from other places as well:
https://github.com/search?q=repo%3AJetBrains%2Fcompose-multiplatform%20org.jetbrains.compose.experimental.uikit.enabled&type=code

(in support/1.5.10 branch)

@dima-avdeev-jb
Copy link
Contributor Author

We should remove it from other places as well: https://github.com/search?q=repo%3AJetBrains%2Fcompose-multiplatform%20org.jetbrains.compose.experimental.uikit.enabled&type=code

(in support/1.5.10 branch)

Done in this commit: c642f7f

@dima-avdeev-jb dima-avdeev-jb merged commit fd6d6c8 into master Sep 30, 2023
6 checks passed
@dima-avdeev-jb dima-avdeev-jb deleted the dima.avdeev/COMPOSE-338-remove-uikit-experimental-flag branch September 30, 2023 00:28
@dima-avdeev-jb
Copy link
Contributor Author

dima-avdeev-jb commented Sep 30, 2023

Done in this commit: c642f7f

It was my mistake, because now branch fails to compile.
Reverted it in support/1.5.10 branch
First we need to wait existing versions on maven with completed Issue.
And after that - merge PR: #3752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants