run k/wasm tests in resources library #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This a follow up to: #4028 |
eymar
force-pushed
the
ok/run_kwasm_tests_in_resources_library
branch
from
f1d1abb
to
88d7f89
Compare
eymar
changed the title
eymar
commented
Dec 12, 2023
| @@ -2,7 +2,9 @@ package org.jetbrains.compose.resources | |||
|
|
|||
| import kotlinx.coroutines.CoroutineScope | |||
|
|
|||
| expect fun runBlockingTest(block: suspend CoroutineScope.() -> Unit) | |||
| expect class TestReturnType | |||
There was a problem hiding this comment.
The test return type is different on platforms:
- void for k/jvm and k/native
- Promise<*> for k/js and k/wasm
Therefore we need to distinguish between them to ensure the compilation works.
terrakok
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.