-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script for generating changelogs, new template for PR's #4351
Conversation
Keeping it as a draft until it proved itself useful |
2c953f8
to
cb6aea4
Compare
In this PR the new formatting applied: - categories are not sections, they integrated in the title - platforms are defined as labels - highlighted fixes are bold Generated by [the script](#4351) from the list of commits and PR's
tools/changelog.main.kts
Outdated
commit | ||
} | ||
|
||
fun ChangelogEntry.format() = if (link != null) "$message ([link]($link))" else message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we're using different format
fun ChangelogEntry.format() = if (link != null) "$message ([link]($link))" else message | |
fun ChangelogEntry.format() = if (link != null) "- [$message]($link)" else message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
tools/changelog.main.kts
Outdated
val entries = entriesForRepo("JetBrains/compose-multiplatform-core") + | ||
entriesForRepo("JetBrains/compose-multiplatform") | ||
|
||
println("\n# CHANGELOG") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
println("\n# CHANGELOG") | |
println("\n# ${version} (${currentMonth})") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
e01084f
to
407dc3a
Compare
85c654d
to
f5910b9
Compare
New features in the last commits:
|
@MatkovIvan, it is ready for merge, could you review it? |
tools/changelog.main.kts
Outdated
fun String.removeLinks(): String = replace(Regex("\\[([^)]*)\\]\\([^\\]]*\\)"), "$1") | ||
|
||
/** | ||
* Extract by format https://github.com/JetBrains/compose-multiplatform/blob/b32350459acceb9cca6b9e4422b7aaa051d9ae7d/.github/PULL_REQUEST_TEMPLATE.md?plain=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we refer jb-main
instead b32350459acceb9cca6b9e4422b7aaa051d9ae7d
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
section = s.substringBefore("-", "").trim().ifEmpty { null } | ||
subsection = s.substringAfter("-", "").trim().ifEmpty { null } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's print some warning if it's not in the predefined list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
No description provided.