-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update compose compiler version to 1.5.13 #4770
Conversation
gradle-plugins/gradle.properties
Outdated
@@ -10,7 +10,7 @@ dev.junit.parallel=false | |||
# Default version of Compose Libraries used by Gradle plugin | |||
compose.version=1.6.10-dev1590 | |||
# The latest version of Compose Compiler used by Gradle plugin. Used only in tests/CI. | |||
compose.tests.compiler.version=1.5.10.2 | |||
compose.tests.compiler.version=1.5.12 | |||
# The latest version of Kotlin compatible with compose.tests.compiler.version. Used only in tests/CI. | |||
compose.tests.compiler.compatible.kotlin.version=1.9.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it should be 1.9.24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -23,7 +23,8 @@ internal object ComposeCompilerCompatibility { | |||
"1.9.20" to "1.5.3", | |||
"1.9.21" to "1.5.4", | |||
"1.9.22" to "1.5.8.1", | |||
"1.9.23" to "1.5.10.2", | |||
"1.9.23" to "1.5.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected that 1.5.12 will be used for kotlin 1.9.23? Or is it an accidental change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jetpack compose 1.5.12 is compatible with 1.9.23, so it is probably a good thing to have our 1.5.12 compatible with it also
https://developer.android.com/jetpack/androidx/releases/compose-kotlin#pre-release_kotlin_compatibility
also, Ive noted that 1.5.13 is up, so probably we should abandon these pulls and support 1.5.13 for both 1.9.23 and 1.9.24?
@@ -23,7 +23,8 @@ internal object ComposeCompilerCompatibility { | |||
"1.9.20" to "1.5.3", | |||
"1.9.21" to "1.5.4", | |||
"1.9.22" to "1.5.8.1", | |||
"1.9.23" to "1.5.10.2", | |||
"1.9.23" to "1.5.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks suspicious. Usually one version of compose compiler supports only one version of kotlin.
Or did you disable the version checker in the Compose Compiler plugin code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are definitely right, fixed
compose compiler version updated
Testing
Release Notes
Highlights
Compose compiler