Update kotlin version in examples #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
May 21, 2024
eymar
commented
May 22, 2024
| @@ -1,7 +1,7 @@ | |||
| kotlin.code.style=official | |||
| xcodeproj=./iosApp | |||
| android.useAndroidX=true | |||
| org.gradle.jvmargs=-Xmx3g | |||
| org.gradle.jvmargs=-Xmx8g | |||
There was a problem hiding this comment.
increased it here and in other places, becuase otherwise ./gradlew build was failing with OOM. Building the targets separately was fine though.
igordmn
approved these changes
May 22, 2024
MatkovIvan
reviewed
May 22, 2024
eymar
added a commit
that referenced
this pull request
May 29, 2024
Changes:
- update all examples to Kotlin 2.0
- migrate to using kotlin("plugin.compose") for Compose compiler
configuration
- remove deprecated Compose Web gradle API usages
- added a workaround for
#4848 in
Jetsnack example
Testing:
- `./gradlew build` in every example
- run some examples in simulators (or desktop, browser)
(cherry picked from commit 4c01cbd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
update all examples to Kotlin 2.0
migrate to using kotlin("plugin.compose") for Compose compiler configuration
remove deprecated Compose Web gradle API usages
added a workaround for Compose Compiler (iOS): public Composable functions in expect/actual class is attempted to be exported to ObjC #4848 in Jetsnack example
Testing:
./gradlew buildin every example