[Android] update Font with new resource value #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrakok
pushed a commit
that referenced
this pull request
May 28, 2024
Fixes #4863 Before this update, when a new `resource` value was passed to `org.jetbrains.compose.resources.Font` composable, it kept the original value. Test sample code. `Res.font` here is autogenerated from `commonMain/composeResources/font/` folder content. ```kt var flag by remember { mutableStateOf(false) } Column { Text( "hey", fontFamily = FontFamily(Font(if (flag) Res.font.HelveticaNeueMedium else Res.font.COMICSANS, FontWeight.Normal)) ) Switch(checked = flag, onCheckedChange = { flag = it }) } ``` ## Release Notes ### Fixes - Resources - Fix a cached font if the resource acessor was changed (cherry picked from commit 0485f03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4863
Before this update, when a new
resourcevalue was passed toorg.jetbrains.compose.resources.Fontcomposable, it kept the original value.Test sample code.
Res.fonthere is autogenerated fromcommonMain/composeResources/font/folder content.Release Notes
Fixes - Resources