Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resources] Delete Thread.currentThread().contextClassLoader on JVM targets #4895

Merged
merged 1 commit into from
May 29, 2024

Conversation

terrakok
Copy link
Collaborator

@terrakok terrakok commented May 29, 2024

The class loader retrieval method has been modified in both ResourceReader.android.kt and ResourceReader.desktop.kt files. The return statement has been changed to prioritize java class classLoader and provides a clearer error message when it can't be found.

Fixes #4887
Fixes #4742

Release Notes

Fixes - Resources

  • Delete contextClassLoader usage on JVM targets

…argets

The class loader retrieval method has been modified in both `ResourceReader.android.kt` and `ResourceReader.desktop.kt` files. The return statement has been changed to prioritize java class classLoader and provides a clearer error message when it can't be found.
@terrakok terrakok requested a review from igordmn May 29, 2024 10:32
@terrakok terrakok merged commit c519a69 into master May 29, 2024
@terrakok terrakok deleted the k.tskh/classlodaer branch May 29, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants