Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file associations support documentation #5054

Merged
merged 8 commits into from
Jul 2, 2024

Conversation

zhelenskiy
Copy link
Member

Docs for file associations support (#4957) which fixes #773.

@zhelenskiy zhelenskiy changed the base branch from master to support/1.7.0 July 1, 2024 20:35
@igordmn igordmn requested review from zamulla and igordmn July 2, 2024 15:18
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will send to copyediting after approve from Zamulla

Copy link
Contributor

@zamulla zamulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most importantly I think we would benefits from comments in the code, other suggestions are phrasing polish.

zhelenskiy and others added 7 commits July 2, 2024 18:10
Co-authored-by: Aleksey Zamulla <aleksey.zamulla@jetbrains.com>
Co-authored-by: Aleksey Zamulla <aleksey.zamulla@jetbrains.com>
Co-authored-by: Aleksey Zamulla <aleksey.zamulla@jetbrains.com>
Co-authored-by: Aleksey Zamulla <aleksey.zamulla@jetbrains.com>
Co-authored-by: Aleksey Zamulla <aleksey.zamulla@jetbrains.com>
Co-authored-by: Aleksey Zamulla <aleksey.zamulla@jetbrains.com>
Co-authored-by: Aleksey Zamulla <aleksey.zamulla@jetbrains.com>
@zhelenskiy zhelenskiy requested a review from zamulla July 2, 2024 16:13
Copy link
Contributor

@zamulla zamulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good 👍

@igordmn igordmn merged commit 810745f into JetBrains:support/1.7.0 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop: Add support for file associations
3 participants