-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial implementation of virtualedit config #242
Conversation
Yep, thanks for the contribution. We have a pre-release freeze, so I'll check the PR right after the release. Are you going to support other settings, or you're interested in this particular one? The both answers are perfectly fine, but I just want to understand your goals :) |
My primary purpose was to support |
@AlexPl292 : Updated to fix conflicts. |
HI! I've just checked the PR. Unfortunately, it looks like it would be a bit more complicated. Here are some inconsistencies I was able to find:
Could you please check these cases and write some tests to prove the implementation? Also, it looks like there are some unnecessary files in the PR. |
Thanks for the detailed feedback. I'll try to correct those issues as soon as possible. |
30ade61
to
702ff40
Compare
Hi @AlexPl292 . It turns out the interaction between |
This does not support all config settings, but does add the 'onemore' option. This partly addresses https://youtrack.jetbrains.com/issue/VIM-844
Updated against upstream. As far as I'm aware, there are no other changes required? |
Hi! I was able to perform some more aggressive refactorings that allowed me to reach the desired behaviour without additional workarounds. I hope this won't give us any other difficulties. |
This does not support all config settings,
but does add the 'onemore' option.
This partly addresses https://youtrack.jetbrains.com/issue/VIM-844