Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIM-2255] Missing reload icon in .ideavimrc on Windows #390

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

chylex
Copy link
Contributor

@chylex chylex commented Oct 24, 2021

https://youtrack.jetbrains.com/issue/VIM-2255

Due to:

  fun saveFileState(filePath: String, text: String) {
    this.filePath = FileUtil.toSystemDependentName(filePath)
    // ....
  }

the path never matches, since on Windows, virtualFile.path has forward slashes and VimRcFileState.filePath has backslashes.

@chylex
Copy link
Contributor Author

chylex commented Oct 24, 2021

I also noticed another issue that happens on all operating systems - the reload button doesn't appear if .ideavimrc is opened as IJ is starting (for ex. if you open the file and then restart IJ), as VimRcFileState.filePath is not initialized this early so the comparison also fails.

@AlexPl292 AlexPl292 merged commit 637ae21 into JetBrains:master Oct 29, 2021
@AlexPl292
Copy link
Member

Hi, thank you for the reload action reviewing. I've merged your changes and added a fix for the button when IJ starts with ideavimrc.

@chylex chylex deleted the VIM-2255 branch November 2, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants