Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile errors in unit tests on Windows #418

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

chylex
Copy link
Contributor

@chylex chylex commented Nov 30, 2021

JVM on Windows doesn't use UTF-8, so compilation of unit test sources with special characters fails on Windows:

assertIsKeyword('Ā');
// unclosed character literal
// unclosed character literal
// not a statement

Discussion: #389

Unfortunately I don't know how to fix the doc folder containing files with quotes, which are illegal on Windows. In case anyone finds this, all I can recommend is this command to remove the doc folder altogether, so that git status doesn't constantly complain about missing files:

git submodule deinit -f doc

@AlexPl292
Copy link
Member

Nice!
I wanted to get rid of doc directory as a submodule for some time already, looke like I can do it now.

@AlexPl292 AlexPl292 merged commit b6d84e0 into JetBrains:master Dec 1, 2021
@chylex chylex deleted the fix-windows-compile branch December 1, 2021 06:57
@chylex
Copy link
Contributor Author

chylex commented Dec 1, 2021

I think removing the submodule but keeping the .md files will make it worse; removing the submodule effectively hid the illegally named files from git, so it wouldn't cause trouble because it wouldn't even try to pull them into Windows :P

Could you please rename these two .md files

so they don't have quotes in the filename?

@AlexPl292
Copy link
Member

Oops, sorry. Actually github wiki forced me to use the quotes in the name, so now it's fine to remove them. Already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants