[kotlin] J2K: Correctly reference inner class types in outer class header #2807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J2K is being a little ovezealous when adding imports for nested, locally defined types. In K1, postprocessing handles most of the clean up, though it still misses type references in outer class headers. In addition to fixing the references-in-outer-class-headers bug (which produces unbuildable kotlin code), we can improve output for K1 & K2 modes by applying a few rules during type symbol printing:
I wish I could move this logic out of the printing phase and somewhere earlier, but I'm not sure how to do that without a significant refactor of how type symbols are handled.
@abelkov @darthorimar @jocelynluizzi13