IDEA-80032 Support classifiers with Maven sources #2826
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue when using a Maven dependency with a classifier. Previously, the sources without the classifier would be downloaded. This modifies the behavior to download the sources with the classifier.
I didn't find any tests to edit for WorkspaceModuleImporter.kt, but if there's something existing I can update it.
A few notes before merging.
primefaces-14.0.4-jakarta.jar
and sometimes it shows asprimefaces-14.0.4-jakarta-sources.jar
.Manual Test Steps
Maven: org.primefaces:primefaces:jakarta:14.0.4
and expand the library.org.primefaces.application.exceptionhandler.PrimeExceptionHandler
class and review the imports at the top of the file, confirm they are thejakarta
imports.classifier
from the dependency.javax
imports are used now.Maven: org.primefaces:primefaces:14.0.4
and expand the library.org.primefaces.application.exceptionhandler.PrimeExceptionHandler
class and review the imports at the top of the file, confirm they are thejavax
imports.