Making junit plugin using default test runner in case Spock testing framework is detected in classpath.
#2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… framework is detected in classpath. Currently, when spock jar is in classpath, for example `spock-core-2.3-groovy-4.0.jar`, the IDE junit plugin detects PSI from the jar `org.junit.platform.engine.TestEngine` with value `org.spockframework.runtime.SpockEngine`. By that the IDE forces to use Junit5. In case a project uses Spock with combination of Junit4 such detection logic makes junit4 test detection impossible when the tests are performed per package or project. Withing the fix the IDE detects Spock and Junit4 tests simultaneously.
|
Hi! Thanks for your patch, would you be able to add a test? |
|
Hi, sure. I am new in the community and would like to see and example for tests here. Also scope of what is testable outcome. |
|
Looking at it again, it seems like testing would be challenging here. I'll run your patch on CI, if there aren't any problems, it should be merged today. The fix will then be available starting from the next 2024.3 EAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.