Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Compose Desktop ProGuard support to IntelliJPlugin #1170

Draft
wants to merge 4 commits into
base: 1.x
Choose a base branch
from

Conversation

mrjameshamilton
Copy link

Pull Request Details

This is a first attempt at porting the ProGuard support from Compose Desktop Gradle Plugin to the IntelliJ Gradle Plugin.

Description

Recently, ProGuard support was added to the Compose Desktop Gradle plugin by adding a Gradle task which configures & executes ProGuard, and a simple DSL configuration.

This PR copies the AbstractProguardTask, ProguardSettings and related utility code.

Some of the utility code is probably not required and can be removed but currently I copied & pasted complete files.

I've slightly modified the AbstractProguardTask to make it work in the IntelliJ Gradle Plugin: mostly for collecting the library jars (which should maybe be done instead in the IntelliJ Plugin?) and making the mainClass optional.

I've added a configureProguardTask in the IntelliJPlugin to configure the plugin and set the input & output files.

A plugin block can be added to an IntelliJ Plugin project:

tasks {
     ...
    proguard {
        configurationFiles.from("proguard-rules.pro")
       dontobfuscate.set(false)
    }
}

Running the ./gradlew proguard command currently produces a proguarded jar in build/lib/proguard/ but this may not be the most appropriate location. The publish task should also be able to publish this version of the jar instead of the original.

A default ProGuard rules file is added to the resources. We should add some default rules to the configuration that make sense for IntelliJ Plugin projects.

We should probably also print the various logging files by default into the build folder; especially the mapping.txt file when obfuscation is enabled (-printmapping mapping.txt).

Motivation and Context

Provide a simplified integration for ProGuard shrinking, optimization and name obfuscation compared to e.g. using the current ProGuardTask

How Has This Been Tested

Currently manually tested on a small sample: please advise on how this should normally be tested.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have included my change in the CHANGELOG.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mrjameshamilton mrjameshamilton marked this pull request as draft October 19, 2022 14:18
@hsz hsz force-pushed the master branch 3 times, most recently from 28a9664 to 2668303 Compare December 16, 2022 17:14
@hsz hsz added this to the next milestone Mar 29, 2023
@hsz hsz self-assigned this Mar 29, 2023
@hsz hsz removed this from the next milestone Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants