Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 - Use the built-in Gradle version checker #1549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hfhbd
Copy link
Contributor

@hfhbd hfhbd commented Mar 2, 2024

Pull Request Details

Gradle added the GradlePluginApiVersion.GRADLE_PLUGIN_API_VERSION_ATTRIBUTE to use the build-in variant mechanism to select a compatible Gradle plugin, or fails the build. The downside of the build-in option is the massive wall of text (the variant error output) when you consume your Gradle plugin with a lower Gradle version, eg 8.0.

But, starting with Gradle 8.7, the variant error output is more human readable: gradle/gradle#24609

This PR removes the custom check but with down-side of suboptimal experience using Gradle < 8.7.

Question: Do you want it?

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have included my change in the CHANGELOG.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hfhbd hfhbd changed the title Use the built-in Gradle version checker 2.0 - Use the built-in Gradle version checker Mar 2, 2024
@hfhbd hfhbd force-pushed the gradleVersionAttribute branch from cac422e to 2e65a6b Compare March 2, 2024 13:01
@YannCebron YannCebron requested a review from hsz March 5, 2024 09:43
@YannCebron YannCebron added this to the 2.x milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants