feature: PausableComposition feature flag in CCGP #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapchicoma
approved these changes
Nov 13, 2024
| @@ -194,6 +194,27 @@ and functions that are implicitly not skippable (inline functions and functions | |||
| > | |||
| {style="warning"} | |||
|
|
|||
| ### PausableComposition | |||
|
|
|||
| > The feature flag affects behavior only with a version of Compose runtime that supports pausable composition, | |||
There was a problem hiding this comment.
Why not combine the info and warning into one warning at the top? If the warning is at the bottom of the text then readers can miss it if they don't read through all the content. Or think the warning is applicable to the next section. WDYT? :)
Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioning the PausableComposition flag in the Compose Compiler Gradle plugin reference: https://youtrack.jetbrains.com/issue/KT-71227/Compose-Add-PausableComposition-feature-flag-to-the-Compose-Gradle-Plugin