Fix repository ID generation for Maven resolver #4361
Conversation
| @@ -81,6 +81,15 @@ class MavenResolverTest : ResolversTestBase() { | |||
| } | |||
| } | |||
|
|
|||
| fun testCustomRepositoryId() { | |||
There was a problem hiding this comment.
@ligee I can ignore this test if you wish, but I don't know a way of testing this except using custom repositories
There was a problem hiding this comment.
Yes, please ignore it, the test below gives a good explanation comment, you can simply copy it.
I also think that it is a half-good test anyway because for a good one you'd need to test all OS-es separately.
But it is good to have it here anyway, so at least we can test it manually.
ileasile
force-pushed
the
rr/ileasile/fix-repo-id-in-maven-resolver
branch
from
8daa880
to
e4b04e9
Compare
| @@ -81,6 +81,15 @@ class MavenResolverTest : ResolversTestBase() { | |||
| } | |||
| } | |||
|
|
|||
| fun testCustomRepositoryId() { | |||
There was a problem hiding this comment.
Yes, please ignore it, the test below gives a good explanation comment, you can simply copy it.
I also think that it is a half-good test anyway because for a good one you'd need to test all OS-es separately.
But it is good to have it here anyway, so at least we can test it manually.
|
Merged manually: 626c1d3 |
No description provided.