🧪 Fix IDE tests

core/installers_test.go

@@ -20,7 +20,6 @@ import (
 	"github.com/JetBrains/qodana-cli/v2024/platform"
 	"os"
 	"path/filepath"
-	"runtime"
 	"testing"
 )
 
@@ -53,18 +52,13 @@ func TestDownloadAndInstallIDE(t *testing.T) {
 }
 
 func DownloadAndInstallIDE(ideName string, t *testing.T) {
-	tempDir, err := os.MkdirTemp("", "productByCode")
+	tempDir := filepath.Join(os.TempDir(), ".qodana_scan_", "ideTest")
+	err := os.MkdirAll(tempDir, 0755)
 	if err != nil {
 		platform.ErrorMessage("Cannot create temp dir: %s", err)
+		t.Fail()
 	}
 
-	defer func(path string) {
-		err := os.RemoveAll(path)
-		if err != nil {
-			platform.ErrorMessage("Cannot clean up temp dir: %s", err)
-		}
-	}(tempDir) // clean up
-
 	opts := &QodanaOptions{
 		&platform.QodanaOptions{
 			Ide: ideName,
@@ -75,18 +69,10 @@ func DownloadAndInstallIDE(ideName string, t *testing.T) {
 		platform.ErrorMessage("Cannot install %s", ideName)
 		t.Fail()
 	}
-
-	if //goland:noinspection GoBoolExpressions
-	runtime.GOOS == "darwin" {
-		ide = filepath.Join(ide, "Contents")
-	}
 	prod, err := readIdeProductInfo(ide)
-	defer func(path string) {
-		err := os.RemoveAll(path)
-		if err != nil {
-			platform.ErrorMessage("Cannot clean up temp dir: %s", err)
-		}
-	}(ide) // clean up
+	if err != nil || prod == nil {
+		t.Fatalf("Failed to read IDE product info: %v", err)
+	}
 	if prod.ProductCode == "" {
 		t.Fail()
 	}