Offscreen, Linux. Fix native crash when OpenGL isn't available #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, fallback to Software. Discovered during #876 investigation
igordmn
requested review from
Walingar and
elijah-semyonov
and removed request for
Walingar
elijah-semyonov
approved these changes
Feb 26, 2024
This was referenced Feb 27, 2024
igordmn
added a commit
that referenced
this pull request
Feb 28, 2024
Instead, fallback to Software. Discovered during #876 investigation ## Explanation We throw RenderException, and Fallback mechanism catches it and switches to Software ## Testing 1. Setup the system without OpenGL 2. Run SkiaSwingLayer 3. See the native crash
igordmn
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this pull request
Feb 29, 2024
## Proposed Changes A diff is JetBrains/skiko@v0.7.93...v0.7.94 ## Issues Fixed [Offscreen, Linux. Fix native crash when OpenGL isn't available](JetBrains/skiko#877) [Fix loadOpenGLLibrary for web targets](JetBrains/skiko#875)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, fallback to Software.
Discovered during #876 investigation
Explanation
We throw RenderException, and Fallback mechanism catches it and switches to Software
Testing