Remove FEATURE_NETCORE_REFLECTION_API and related code

This is dead code; with the previous switch to netstandard2.0, the missing functions became available  and this code stopped being built.

castleproject#612 - Updating Windsor to support Castle.Core@5.0.0 and modern TFMs

README.md

@@ -37,7 +37,6 @@ Symbol                              | .NET 4.5           | .NET Standard
 `FEATURE_GAC`                       | :white_check_mark: | :no_entry_sign:
 `FEATURE_GETCALLINGASSEMBLY`        | :white_check_mark: | :no_entry_sign:
 `FEATURE_ISUPPORTINITIALIZE`        | :white_check_mark: | :no_entry_sign:
-`FEATURE_NETCORE_REFLECTION_API`    | :no_entry_sign:    | :white_check_mark:
 `FEATURE_PERFCOUNTERS`              | :white_check_mark: | :no_entry_sign:
 `FEATURE_REMOTING`                  | :white_check_mark: | :no_entry_sign:
 `FEATURE_SECURITY_PERMISSIONS`      | :white_check_mark: | :no_entry_sign:
@@ -52,7 +51,6 @@ Symbol                              | .NET 4.5           | .NET Standard
 * `FEATURE_GAC` - enables support for obtaining assemblies using an assembly's long form name.
 * `FEATURE_GETCALLINGASSEMBLY` - enables code that uses `System.Reflection.Assembly.GetCallingAssembly()`.
 * `FEATURE_ISUPPORTINITIALIZE` - enables support for features that make use of `System.ComponentModel.ISupportInitialize`.
-* `FEATURE_NETCORE_REFLECTION_API` - provides shims to implement missing functionality in .NET Core that have no alternatives.
 * `FEATURE_PERFCOUNTERS` - enables code that uses Windows Performance Counters.
 * `FEATURE_REMOTING` - supports remoting on various types including inheriting from `MarshalByRefObject`.
 * `FEATURE_SECURITY_PERMISSIONS` - enables the use of CAS and `Security[Critical|SafeCritical|Transparent]`.

buildscripts/common.props

@@ -39,10 +39,6 @@
 		<DefineConstants>$(DefineConstants);FEATURE_PERFCOUNTERS;FEATURE_GAC;FEATURE_ISUPPORTINITIALIZE;FEATURE_REMOTING;FEATURE_SECURITY_PERMISSIONS;FEATURE_SYSTEM_CONFIGURATION;FEATURE_SERIALIZATION;FEATURE_URIMEMBERS;FEATURE_GETCALLINGASSEMBLY;FEATURE_APPDOMAIN;FEATURE_CODEDOM;FEATURE_ASSEMBLIES;CASTLE_SERVICES_LOGGING;FEATURE_EVENTLOG</DefineConstants>
 	</PropertyGroup>
 
-	<PropertyGroup Condition="'$(TargetFramework)'=='netstandard1.6'">
-		<DefineConstants>$(DefineConstants);FEATURE_NETCORE_REFLECTION_API</DefineConstants>
-	</PropertyGroup>
-
 	<ItemGroup>
 		<Content Include="..\..\CHANGELOG.md" />
 		<Content Include="..\..\LICENSE">

src/Castle.Facilities.Logging/Castle.Facilities.Logging.csproj

@@ -24,6 +24,5 @@
 
 	<ItemGroup>
 		<Compile Include="..\..\buildscripts\CommonAssemblyInfo.cs" />
-		<Compile Include="..\Castle.Windsor\Compatibility\NetCoreReflectionExtensions.cs" />
 	</ItemGroup>
 </Project>